design: Platform Bundle integration improvements #318
Conversation
ajaythakurintel
added
the
Proposal
osinstom
changed the title
osinstom
requested review from
scottmbaker,
hyunsun,
teone,
krishnajs,
Andrea-Campanella,
se-chris-thach,
charlesmcchan and
yi-tseng-intel
as code owners
osinstom
requested review from
ashridatta,
callumnobleintel,
daniele-moro,
SeanCondon,
pierventre,
cgoea,
palade,
pperycz,
ltalarcz,
jakubsikorski,
sys-orch-approve,
ahalimx86,
johnoloughlin and
garyloug
as code owners
| - Onboarding Manager: | ||
| - Extract cloud-init template to a separate Go sub-module in infra-onboarding with CI/CD and SemVer versioning | ||
| - Extend Platform Bundle library to handle new YAML format | ||
| - Extend Tinkerbell workflows with action to download Platform Bundle files and write them to target OS file system. |
There was a problem hiding this comment.
Does this tinker action does curation as well or only download and copy to target location?
There was a problem hiding this comment.
Only download and copy, we should not include any placeholders in the Platform Bundle files.
| - Extend Platform Bundle library to handle new YAML format | ||
| - Extend Tinkerbell workflows with action to download Platform Bundle files and write them to target OS file system. | ||
| - Tinker actions: | ||
| - Implement new Tinker action that downloads Release Service artifacts (can be non-OCI to avoid implementing `oras`) and writes them to target OS location |
There was a problem hiding this comment.
If it is possible, we will consider to avoid tinker action to download the installer from RS, we can do it in the cloud-init script itself.
There was a problem hiding this comment.
Yes, this is one of possible optimizations
|
|
||
| ```yaml | ||
| platformBundle: | ||
| files: |
There was a problem hiding this comment.
How is this content verified, to avoid download issues, or maliciously changed content?
Should a checksum or signature be required?
There was a problem hiding this comment.
Yes, skipped that in this example, but SHA256 checksum verification will be part of implementation.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: